Fix template injection in e2e-versions.yml (zizmor alert #122)#1120
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix code scanning alert #122
Fix template injection in e2e-versions.yml (zizmor alert #122)
Jul 14, 2026
Copilot stopped reviewing on behalf of
brunoborges due to an error
July 14, 2026 19:55
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the e2e GitHub Actions workflow to verify Java 21 setup outputs using step-scoped environment variables, improving shell interpolation consistency.
Changes:
- Pass
setup-java-21outputs into the verification step viaenv - Update verification script to reference
$JAVA_21_PATH/$JAVA_21_VERSIONinstead of inline${{ ... }}expressions
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/e2e-versions.yml | Refactors the Java 21 output verification step to use environment variables for easier/safer shell usage |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a
zizmor/template-injectioncode scanning alert by removing direct GitHub expression expansion inside arun:bash script, which could allow shell injection if output values contain metacharacters.Changes:
${{ steps.setup-java-21.outputs.path }}and${{ steps.setup-java-21.outputs.version }}from inline script expansion intoenv:variables (JAVA_21_PATH,JAVA_21_VERSION), consistent with the safe pattern used throughout the rest of the workflow.Related issue:
N/A — code scanning alert #122
Check list:
npm run checklocally (format, lint, build, test) and all checks pass.